Improve graphman remove feedback #6281
Open
+99
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t subgraph Previously, remove_subgraph returned Ok(vecsilently when the subgraph didn't exist. Now it returns a proper StoreError::SubgraphNotFound error with the subgraph name, giving users clear feedback. Signed-off-by: Maksim Dimitrov <[email protected]>
Change the remove command to accept DeploymentSearch and validate that only subgraph names are accepted. Passing an IPFS hash or schema namespace now returns a clear error message instead of being silently treated as a name. Signed-off-by: Maksim Dimitrov <[email protected]>
…olver Add missing .map_err(GraphmanError::from) to properly convert store errors (including the new SubgraphNotFound) to GraphQL errors. Signed-off-by: Maksim Dimitrov <[email protected]>
Signed-off-by: Maksim Dimitrov <[email protected]>
The test was silently passing because remove_subgraph returned Ok(vecfor non-existent subgraphs. Now that SubgraphNotFound error is properly returned, the test needs to actually create the subgraph first. Signed-off-by: Maksim Dimitrov <[email protected]>
…aphs that may not exist Signed-off-by: Maksim Dimitrov <[email protected]>
dimitrovmaksim
changed the title
Signed-off-by: Maksim Dimitrov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6248
This PR improves
graphman removecommand andremovemutation feedback when passing incorrect argument or non existing subgraph name.graphman removeto accept DeploymentSearch to ensure only subgraph names are acceptedStoreError::SubgraphNotFound(String)variant to provide typed errors for missing subgraphsErr(SubgraphNotFound)instead ofOk(vec![])when the subgraph doesn't existSubgraphNotFounderror through the graphman graphql api for non existing subgraphs instead ofsuccess: true