feat: add plugin-directory input to e2e-version#212
Draft
sunker wants to merge 4 commits into
Draft
Conversation
c81db32 to
0939226
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
plugin-directoryinput to thee2e-versionaction so it can findsrc/plugin.jsonin the correct location for plugins that live in a subdirectory (e.g. monorepos).Without this, the action always reads
grafanaDependencyfrom the repo root'ssrc/plugin.json, ignoring the actual plugin location. The only workaround was to manually setgrafana-dependency, which is easy to forget and gets stale.Changes
action.yml: add optionalplugin-directoryinputindex.js: readplugin.jsonfromplugin-directorywhen setREADME.md: document the new inputUsage