Conversation
Registry.Get did not check the result of store.New before dereferencing it. When a Store's New returned (nil, err), the next line (session.name = name) panicked with a nil-pointer dereference instead of returning the error. Guard against a nil session: if store.New returns nil, return the error to the caller. Adds a regression test with a store whose New always fails. Fixes gorilla#288
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #288.
Current behavior
Registry.Getcallsstore.New(...)but does not check its result before use:A
StorewhoseNewreturns(nil, err)— which the interface permits — causes a nil-pointer panic atsession.name = name(and again atsession.store = store), instead of the error being returned to the caller.Fix
Guard against a nil session: if
store.Newreturns nil, return the error immediately rather than dereferencing it.Testing
TestRegistryGet_StoreNewError: a store whoseNewreturns(nil, err)now yields a nil session + error fromGetinstead of panicking.go test .— full suite passes;gofmtclean;go build .clean.