chore(internal/librarian/golang): use cache package for tool installation#6327
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the installation directory resolution in the Java librarian module to use the centralized cache package. Specifically, getInstallDir now retrieves the binary directory via cache.BinDirectory(), and the corresponding test has been updated to use the cache.EnvLibrarianBin constant instead of a hardcoded environment variable string. There are no review comments, and I have no feedback to provide.
JoeWang1127
force-pushed
the
chore/java-bin
branch
from
June 6, 2026 00:12
2977a55 to
e3677fa
Compare
JoeWang1127
changed the title
JoeWang1127
marked this pull request as ready for review
June 6, 2026 14:46
noahdietz
approved these changes
Jun 8, 2026
haphungw
pushed a commit
to haphungw/librarian
that referenced
this pull request
Jun 26, 2026
…tion (googleapis#6327) The Go tool installation and execution logic is updated to use the shared `cache.BinDirectory` helper to resolve the installation path. Go tools are now installed into a `go_tools` subdirectory within the standard binary directory resolved by the `cache` package. For googleapis#5850
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Go tool installation and execution logic is updated to use the shared
cache.BinDirectoryhelper to resolve the installation path.Go tools are now installed into a
go_toolssubdirectory within the standard binary directory resolved by thecachepackage.For #5850