impl(auth): create auth errors based on gax errors#5350
impl(auth): create auth errors based on gax errors#5350alvarowolfx merged 2 commits intogoogleapis:mainfrom
Conversation
|
Split from work on #5310 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5350 +/- ##
=======================================
Coverage 97.79% 97.79%
=======================================
Files 222 222
Lines 46386 46405 +19
=======================================
+ Hits 45364 45383 +19
Misses 1022 1022 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
suzmue
left a comment
There was a problem hiding this comment.
nit: I see in the the tests that the is_transient result we expected changed from this improvement. Might be nice to expand on what exactly has been improved in the description and why we saw that change.
@suzmue I've updated the PR description to mention why is an improvement and addressed other review comments |
Improve how auth errors are classified as transient based on gax errors. Previously, we were just checking if the gax::error had an CredentialError as source and if it was transient. But other gax errors can also be considered transient, based on status code, internal reqwest::Error and etc. This PR creates a helper to be reused across the auth crate.