Skip to content

feat: migrate google-cloud-beyondcorp-clientconnectorservices to librarian #8490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jskeet wants to merge 1 commit into from
+14 −35
Closed

feat: migrate google-cloud-beyondcorp-clientconnectorservices to librarian #8490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion librarian.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,6 @@ libraries:
apis:
- path: google/cloud/beyondcorp/clientconnectorservices/v1
copyright_year: "2026"
skip_generate: true
nodejs:
package_name: '@google-cloud/clientconnectorservices'
Comment thread
jskeet marked this conversation as resolved.
- name: google-cloud-beyondcorp-clientgateways
Expand Down
18 changes: 0 additions & 18 deletions packages/google-cloud-beyondcorp-clientconnectorservices/.OwlBot.yaml
View file
Open in desktop

This file was deleted.

30 changes: 14 additions & 16 deletions packages/google-cloud-beyondcorp-clientconnectorservices/.repo-metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
{
"name": "clientconnectorservices",
"name_pretty": "BeyondCorp API",
"product_documentation": "",
"client_documentation": "https://cloud.google.com/nodejs/docs/reference/clientconnectorservices/latest",
"issue_tracker": "https://github.com/googleapis/google-cloud-node/issues",
"release_level": "preview",
"language": "nodejs",
"repo": "googleapis/google-cloud-node",
"distribution_name": "@google-cloud/clientconnectorservices",
"api_id": "beyondcorp.googleapis.com",
"default_version": "v1",
"requires_billing": true,

@quirogas quirogas Jun 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pearigee do you know what this field is used for? We will need to add it back.

@jskeet jskeet Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe it's used any more - we removed it from the few places it occurred in Python.

@suztomo suztomo Jun 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember it's used for README.md generation, especially whether adding [Enable billing for your project](https://support.google.com/cloud/answer/6293499#enable-billing). step.

@suztomo suztomo Jun 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My memory is from Java. As I see no change in README.md in this pull request, I would say the removal of requires_billing is fine.

@jskeet jskeet Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But that would apply to basically all APIs, wouldn't it? I don't think we have any real signal for this, and would suggest we should stop pretending we do :)

@suztomo suztomo Jun 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Let's remove this field.

"library_type": "GAPIC_AUTO",
"api_shortname": "beyondcorp"
}

"api_description": "Beyondcorp Enterprise provides identity and context aware access controls\nfor enterprise resources and enables zero-trust access. Using the\nBeyondcorp Enterprise APIs, enterprises can set up multi-cloud and on-prem\nconnectivity using the App Connector hybrid connectivity solution.",
"api_id": "beyondcorp.googleapis.com",
"api_shortname": "beyondcorp",
"client_documentation": "https://cloud.google.com/nodejs/docs/reference/clientconnectorservices/latest",
"default_version": "v1",
"distribution_name": "@google-cloud/clientconnectorservices",
"language": "nodejs",
"library_type": "GAPIC_AUTO",
"name": "beyondcorp",
"name_pretty": "BeyondCorp",
Comment on lines +10 to +11

@gemini-code-assist gemini-code-assist Bot Jun 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Do not manually edit generated client configuration JSON files. Any changes or updates to .repo-metadata.json must be made upstream in the generator.

References
  1. Do not manually edit generated client configuration JSON files. Any changes or updates must be made upstream in the generator.

"product_documentation": "https://cloud.google.com/beyondcorp/docs",
"release_level": "stable",
"repo": "googleapis/google-cloud-node"
}
Loading