chore: setup unified lockfile with PNPM workspaces

.github/workflows/presubmit.yaml

@@ -18,6 +18,8 @@ jobs:
       - uses: pnpm/action-setup@v4
         with:
           version: ^10.0.0
+      - name: Install Workspace Dependencies (Frozen Lockfile)
+        run: pnpm install --frozen-lockfile --ignore-scripts
       - run: node --version
       - run: ci/run_conditional_tests.sh
         name: Run unit tests

.github/workflows/windows-presubmit.yaml

@@ -18,6 +18,8 @@ jobs:
       - uses: pnpm/action-setup@v4
         with:
           version: ^10.0.0
+      - name: Install Workspace Dependencies (Frozen Lockfile)
+        run: pnpm install --frozen-lockfile --ignore-scripts
       - run: node --version
       - run: bash ci/run_conditional_tests.sh
         name: Run windows unit tests

.gitignore

@@ -7,7 +7,16 @@ packages/google-cloud/README.md
 packages/*/AUTHORS
 packages/*/CONTRIBUTORS
 packages/*/COPYING
-package-lock.json
 __pycache__
-packages/*/pnpm-lock.yaml
-containers/*/pnpm-lock.yaml
+
+# Ignore all lockfiles globally
+**/package-lock.json
+**/npm-shrinkwrap.json
+**/yarn.lock
+**/bun.lockb
+**/bun.lock
+**/pnpm-lock.yaml
+
+# Allow root pnpm-lock.yaml
+!/pnpm-lock.yaml
+.pnpm-store/

ci/run_conditional_tests.sh

@@ -61,11 +61,10 @@ set -e
 if [[ "${changed}" -eq 0 ]]; then
     echo "no change detected in ci"
 else
-    echo "skipping trigger of tests for now: tracking in #7540"
-    # echo "change detected in ci, we should test everything"
-    # echo "result of git diff ${GIT_DIFF_ARG} ci:"
-    # git diff ${GIT_DIFF_ARG} ci
-    # GIT_DIFF_ARG=""
+    echo "change detected in ci, we should test everything"
+    echo "result of git diff ${GIT_DIFF_ARG} ci:"
+    git diff ${GIT_DIFF_ARG} ci
+    GIT_DIFF_ARG=""
 fi
 
 # Now we have a fixed list, but we can change it to autodetect if

ci/run_single_test.sh

@@ -39,9 +39,9 @@ if [ ${BUILD_TYPE} != "presubmit" ]; then
     export MOCHA_REPORTER=xunit
 fi
 
-# Install dependencies
-echo "pnpm install --ignore-scripts --engine-strict --prod; pnpm install"
-pnpm install --ignore-scripts --engine-strict --prod; pnpm install
+# Dependencies are pre-installed globally at the workspace root.
+# We only execute compilation / prep if required by the package.
+pnpm --filter ...{.} run --if-present compile
 
 
 retval=0

core/packages/gapic-node-processing/test/combine-libraries.test.ts

@@ -84,7 +84,7 @@ describe('combine libraries', () => {
   it('should generate unique final directory paths', async () => {
     const libraryPaths = await generateFinalDirectoryPath(libraryConfigCJS);
     // This should be the amount of unique file paths in the tree directory
-    assert.deepStrictEqual(libraryPaths.length, 100);
+    assert.deepStrictEqual(libraryPaths.length, 97);
 
     // Confirm there are only unique items in the array
     assert.deepStrictEqual(

core/packages/gapic-node-processing/test/fixtures/combined-library/google-cloud-speech/README.md

@@ -69,7 +69,6 @@ Samples are in the [`samples/`]([homepage]/samples) directory. Each sample's `RE
 | list phrase set | [source code](https://github.com/googleapis/google-cloud-node/blob/main/packages/google-cloud-speech/samples/generated/v1/adaptation.list_phrase_set.js) |
 | update custom class | [source code](https://github.com/googleapis/google-cloud-node/blob/main/packages/google-cloud-speech/samples/generated/v1/adaptation.update_custom_class.js) |
 | update phrase set | [source code](https://github.com/googleapis/google-cloud-node/blob/main/packages/google-cloud-speech/samples/generated/v1/adaptation.update_phrase_set.js) |
-| cloud | [source code](https://github.com/googleapis/google-cloud-node/blob/main/packages/google-cloud-speech/samples/generated/v1/snippet_metadata_google.cloud.speech.v1.json) |
 | long running recognize | [source code](https://github.com/googleapis/google-cloud-node/blob/main/packages/google-cloud-speech/samples/generated/v1/speech.long_running_recognize.js) |
 | recognize | [source code](https://github.com/googleapis/google-cloud-node/blob/main/packages/google-cloud-speech/samples/generated/v1/speech.recognize.js) |
 | streaming recognize | [source code](https://github.com/googleapis/google-cloud-node/blob/main/packages/google-cloud-speech/samples/generated/v1/speech.streaming_recognize.js) |
@@ -83,11 +82,9 @@ Samples are in the [`samples/`]([homepage]/samples) directory. Each sample's `RE
 | list phrase set | [source code](https://github.com/googleapis/google-cloud-node/blob/main/packages/google-cloud-speech/samples/generated/v1p1beta1/adaptation.list_phrase_set.js) |
 | update custom class | [source code](https://github.com/googleapis/google-cloud-node/blob/main/packages/google-cloud-speech/samples/generated/v1p1beta1/adaptation.update_custom_class.js) |
 | update phrase set | [source code](https://github.com/googleapis/google-cloud-node/blob/main/packages/google-cloud-speech/samples/generated/v1p1beta1/adaptation.update_phrase_set.js) |
-| cloud | [source code](https://github.com/googleapis/google-cloud-node/blob/main/packages/google-cloud-speech/samples/generated/v1p1beta1/snippet_metadata_google.cloud.speech.v1p1beta1.json) |
 | long running recognize | [source code](https://github.com/googleapis/google-cloud-node/blob/main/packages/google-cloud-speech/samples/generated/v1p1beta1/speech.long_running_recognize.js) |
 | recognize | [source code](https://github.com/googleapis/google-cloud-node/blob/main/packages/google-cloud-speech/samples/generated/v1p1beta1/speech.recognize.js) |
 | streaming recognize | [source code](https://github.com/googleapis/google-cloud-node/blob/main/packages/google-cloud-speech/samples/generated/v1p1beta1/speech.streaming_recognize.js) |
-| cloud | [source code](https://github.com/googleapis/google-cloud-node/blob/main/packages/google-cloud-speech/samples/generated/v2/snippet_metadata_google.cloud.speech.v2.json) |
 | batch recognize | [source code](https://github.com/googleapis/google-cloud-node/blob/main/packages/google-cloud-speech/samples/generated/v2/speech.batch_recognize.js) |
 | create custom class | [source code](https://github.com/googleapis/google-cloud-node/blob/main/packages/google-cloud-speech/samples/generated/v2/speech.create_custom_class.js) |
 | create phrase set | [source code](https://github.com/googleapis/google-cloud-node/blob/main/packages/google-cloud-speech/samples/generated/v2/speech.create_phrase_set.js) |

core/packages/gapic-node-processing/test/generate-readme.test.ts

@@ -54,7 +54,7 @@ describe('generate readme.ts', () => {
     const samples = await getSamplesMetadata(
       path.join(COMBINED_LIBRARY_PATH, LIB_POST_COMBINATION),
     );
-    assert.deepStrictEqual(samples.length, 52);
+    assert.deepStrictEqual(samples.length, 49);
 
     // Randomly check that some samples exist
     assert.ok(

core/packages/gcp-metadata/package.json

@@ -40,7 +40,7 @@
   "author": "Google LLC",
   "license": "Apache-2.0",
   "dependencies": {
-    "gaxios": "7.1.3",
+    "gaxios": "7.1.4",
     "google-logging-utils": "1.1.3",
     "json-bigint": "^1.0.0"
   },

core/packages/nodejs-googleapis-common/package.json

@@ -37,7 +37,7 @@
   "license": "Apache-2.0",
   "dependencies": {
     "extend": "^3.0.2",
-    "gaxios": "7.1.3",
+    "gaxios": "7.1.4",
     "google-auth-library": "10.5.0",
     "google-logging-utils": "1.1.3",
     "qs": "^6.7.0",