Start adding valid_data as a Channel flow-control type#4189
Draft
copybara-service[bot] wants to merge 1 commit intomainfrom
Draft
Start adding valid_data as a Channel flow-control type#4189copybara-service[bot] wants to merge 1 commit intomainfrom
valid_data as a Channel flow-control type#4189copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
For now, we put placeholder errors in every place where this could possibly affect how we handle channels. The goal is that this will be used for channels that don't support backpressure - probably with a codegen option to add an assert if data is ever received by a proc that isn't actually ready to receive the incoming data. PiperOrigin-RevId: 908424957
copybara-service
Bot
force-pushed
the
test_908424957
branch
from
2f7888a to
c6c6d2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start adding
valid_dataas a Channel flow-control typeFor now, we put placeholder errors in every place where this could possibly affect how we handle channels. The goal is that this will be used for channels that don't support backpressure - probably with a codegen option to add an assert if data is ever received by a proc that isn't actually ready to receive the incoming data.