[Explicit State Access] Codegen support for unread/multi-read Next nodes without optimization passes#4177
Draft
copybara-service[bot] wants to merge 1 commit intomainfrom
Draft
[Explicit State Access] Codegen support for unread/multi-read Next nodes without optimization passes#4177copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
…des without optimization passes This change enables the codegen pipeline to handle `Next` nodes that reference a `StateElement` directly, without an associated `StateRead`. - Update `CalculateConcurrentStages` and `InsertPipelineRegisters` in `pipeline_register_insertion_pass.cc` to query `Proc` for state reads when a `Next` node doesn't have one. - Add a new test case `ProcWithExplicitStateAccessNewApi` in `convert_to_block_test.cc` using the new API and verify it completes codegen successfully. PiperOrigin-RevId: 906504274
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Explicit State Access] Codegen support for unread/multi-read Next nodes without optimization passes
This change enables the codegen pipeline to handle
Nextnodes that reference aStateElementdirectly, without an associatedStateRead.CalculateConcurrentStagesandInsertPipelineRegistersinpipeline_register_insertion_pass.ccto queryProcfor state reads when aNextnode doesn't have one.ProcWithExplicitStateAccessNewApiinconvert_to_block_test.ccusing the new API and verify it completes codegen successfully.