[dslx] Improve lowering of one_hot_sel and priority_sel builtins#4176
Open
cdleary wants to merge 1 commit intogoogle:mainfrom
Open
[dslx] Improve lowering of one_hot_sel and priority_sel builtins#4176cdleary wants to merge 1 commit intogoogle:mainfrom
cdleary wants to merge 1 commit intogoogle:mainfrom
Conversation
Inline array literals passed to one_hot_sel and priority_sel can already be scalarized directly during IR conversion. Do that before generic argument lowering so no-opt IR does not materialize a temporary array and then recover its members with constant array_index nodes. Keep the existing array-index fallback for non-literal case expressions, and preserve ellipsis expansion for literal arrays.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline array literals passed to one_hot_sel and priority_sel can already be scalarized directly during IR conversion. Do that before generic argument lowering so no-opt IR does not materialize a temporary array and then recover its members with constant array_index nodes.
Keep the existing array-index fallback for non-literal case expressions, and preserve ellipsis expansion for literal arrays.