[TPU/Raiden/FaultInjection] Replace transfer_send_session.push.task with raiden_manager_base.h2h.write - #1037
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_987252591
branch
from
September 24, 2026 06:10
adabf3b to
695254a
Compare
…ith raiden_manager_base.h2h.write ## Why `transfer_send_session.push.task` sits at the start of the `push_pool` lambda rather than a concrete operation boundary, making it less useful for testing transport error handling. Replace it with an injection point right before `transport->AsyncPush` in `H2hWriteDirectAsync`. ## What * Remove `transfer_send_session.push.task`. * Add `raiden_manager_base.h2h.write` (`kRaidenManagerBaseH2hWrite`) inside `RaidenManagerBase::H2hWriteDirectAsync`, reporting injected failures through `on_complete(status)`. PiperOrigin-RevId: 987267146
copybara-service
Bot
force-pushed
the
test_987252591
branch
from
September 24, 2026 06:31
695254a to
b1cd932
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[TPU/Raiden/FaultInjection] Replace transfer_send_session.push.task with raiden_manager_base.h2h.write
Why
transfer_send_session.push.tasksits at the start of thepush_poollambda rather than a concrete operation boundary, making it less useful for
testing transport error handling. Replace it with an injection point right
before
transport->AsyncPushinH2hWriteDirectAsync.What
transfer_send_session.push.task.raiden_manager_base.h2h.write(kRaidenManagerBaseH2hWrite) insideRaidenManagerBase::H2hWriteDirectAsync, reporting injected failuresthrough
on_complete(status).