Fix a self-deadlock in HostOffloadBackend's remote-write completion. - #1031
Merged
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_986211272
branch
2 times, most recently
from
September 24, 2026 05:54
c701088 to
c32d310
Compare
In BeginWriteRemote, release lifetime->mu before registering poll_future.OnReady and use ReaderMutexLock in both callbacks. Previously, registering OnReady while holding lifetime->mu deadlocked whenever poll_future was already resolved by the time OnReady was called (either because the PollWriteRemote RPC completed quickly or because client resolution failed synchronously), causing OnReady to run inline on the same thread and re-acquire lifetime->mu. PiperOrigin-RevId: 987268928
copybara-service
Bot
force-pushed
the
test_986211272
branch
from
September 24, 2026 06:35
c32d310 to
f65108d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a self-deadlock in HostOffloadBackend's remote-write completion.
In BeginWriteRemote, release lifetime->mu before registering poll_future.OnReady
and use ReaderMutexLock in both callbacks.
Previously, registering OnReady while holding lifetime->mu deadlocked whenever poll_future was already resolved by the time OnReady was called (either because the PollWriteRemote RPC completed quickly or because client resolution failed synchronously), causing OnReady to run inline on the same thread and re-acquire lifetime->mu.