Add PHPUnit messages for test assertions.#12901
Open
JakePT wants to merge 2 commits into
Open
Conversation
1 task
techanvil
requested changes
Jun 19, 2026
Comment on lines
+79
to
+83
| $this->assertEqualSets( | ||
| array( 'foo', 'bar' ), | ||
| $response->get_data(), | ||
| 'Dismissed items response should contain non-expired items.' | ||
| ); |
Collaborator
There was a problem hiding this comment.
The indentation is off here, and in the changes further down in this file.
Not sure why this isn't caught by the linter, but please fix it. We'll have to see what's up with the linting rules.
Collaborator
Author
There was a problem hiding this comment.
@techanvil Fixed. I identified the issue with the linter and opened an issue here: #12934.
Comment on lines
+368
to
+372
| $this->assertEqualSets( | ||
| array( $shared_admin, $shared_editor ), | ||
| wp_list_pluck( $this->query->get_eligible_users( $current_admin, array( 'per_page' => 20 ) ), 'ID' ), | ||
| 'Eligible users should include deduplicated users.' | ||
| ); |
Collaborator
There was a problem hiding this comment.
Another indentation issue here, and below.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist