Update urls.go: Fix URL canonicalization filter evasion#157
Open
DaftCode101 wants to merge 1 commit intogoogle:masterfrom
Open
Update urls.go: Fix URL canonicalization filter evasion#157DaftCode101 wants to merge 1 commit intogoogle:masterfrom
DaftCode101 wants to merge 1 commit intogoogle:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related VRP Ticket: 501230541
This patch rectifies a path parsing omission in parseURL() to ensure compliance with the Google Safe Browsing API v4 specification.
Previously, the implementation did not scrub backslashes () from the URL string. This allowed for a canonicalization disparity where the Go library would treat backslashes as part of the hostname, diverging from how modern browsers natively normalize them to forward slashes (/).
This 1-line normalization step ensures parity with standard RFC URI behavior and Chrome's native parsing methodologies.