Skip to content

Remediate temporary chaining UAF hazard in security/deflate #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remediate temporary chaining UAF hazard in security/deflate #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deflate/flate2.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ using ::security::crubit_helpers::StringViewFromVecU8;
VecU8Wrapper::VecU8Wrapper(rust::vec_u8::VecU8 vec_u8)
: vec_u8_(std::move(vec_u8)) {}

absl::string_view VecU8Wrapper::as_string_view() const {
absl::string_view VecU8Wrapper::as_string_view() const& {
return StringViewFromVecU8(vec_u8_);
}

Expand Down
3 changes: 2 additions & 1 deletion deflate/flate2.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,8 @@ class GzHeader final {
class VecU8Wrapper {
public:
explicit VecU8Wrapper(rust::vec_u8::VecU8 vec_u8);
absl::string_view as_string_view() const ABSL_ATTRIBUTE_LIFETIME_BOUND;
absl::string_view as_string_view() const& ABSL_ATTRIBUTE_LIFETIME_BOUND;
absl::string_view as_string_view() const&& = delete;
absl::Cord as_cord() &&;

private:
Expand Down
Loading