ui: Allow createPerfettoTable() to take a list of rows as records#6261
Open
stevegolton wants to merge 1 commit into
Open
ui: Allow createPerfettoTable() to take a list of rows as records#6261stevegolton wants to merge 1 commit into
stevegolton wants to merge 1 commit into
Conversation
🎨 Perfetto UI Builds
|
…a string to initialize tables with
e0b9087 to
5008b63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow the
asparam increatePerfettoTable()to be an array of records in order to pre-populate the table with a type-safe list of types.I.e.
So we can use the function like this to initialise a table without having to hand craft the SQL.
This is simply a convenience feature to make it easier to create pre-filled tables, mainly for testing.