Skip to content

fix: improve styling for list page and accordion view#5252

Merged
another-rex merged 2 commits intogoogle:masterfrom
ashmod:fix/light-mode-ui-polish
Apr 23, 2026
Merged

fix: improve styling for list page and accordion view#5252
another-rex merged 2 commits intogoogle:masterfrom
ashmod:fix/light-mode-ui-polish

Conversation

@ashmod
Copy link
Copy Markdown
Contributor

@ashmod ashmod commented Apr 16, 2026

Applies some tiny improvements for styling after light-mode implementation


Fixes 'Published' sort arrow icon visibility in dark mode on the /list page:

(Before)
image

(After)
image


Fixes accordion open state styling in light mode with proper background/text contrast:

(Before)
image

(After)
image


Also, unrelated to theming, reduced the tree structure ending line distance from last child item in accordion view because it looked too spacious.

@ashmod ashmod changed the title fix: improve light mode styling for list page and accordion view fix: improve styling for list page and accordion view Apr 16, 2026
Copy link
Copy Markdown
Member

@michaelkedar michaelkedar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, though I'm wondering if there's a way to keep the red accent colour somehow (or red text on black is just always bad contrast)

@ashmod
Copy link
Copy Markdown
Contributor Author

ashmod commented Apr 22, 2026

I've tried out a few other combinations before I went with the white on black, one of the options would be light red on black, because osv-red wouldn't have the best contrast here:

image
I also tried white on red: image

but colors felt too vibrant I guess.

image

and toning down the red did not help much either.

I eventually went with the current palette because it felt easier on the eyes, but lmk what you think.

@another-rex
Copy link
Copy Markdown
Contributor

Thanks for the alternative screenshots, I think I'm still a fan of the current gray and red, maybe we can make the red text darker for better contrast?
I'm happy with the other changes though, so going to merge this in first and we can follow up with any other color changes.

@another-rex another-rex merged commit 62752f2 into google:master Apr 23, 2026
22 of 23 checks passed
@ashmod
Copy link
Copy Markdown
Contributor Author

ashmod commented Apr 23, 2026

Thanks for the alternative screenshots, I think I'm still a fan of the current gray and red, maybe we can make the red text darker for better contrast?
I'm happy with the other changes though, so going to merge this in first and we can follow up with any other color changes.

Yeah I think a lighter gray + darker red could work better too. Will look into this in the follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants