fix: set ok=False when TestAbortAll is raised in run_suite_class#1006
Open
devimano2011 wants to merge 1 commit intogoogle:masterfrom
Open
fix: set ok=False when TestAbortAll is raised in run_suite_class#1006devimano2011 wants to merge 1 commit intogoogle:masterfrom
devimano2011 wants to merge 1 commit intogoogle:masterfrom
Conversation
Set ok to False when TestAbortAll is caught to indicate failure.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #950 and #960
Problem
In
run_suite_class()insuite_runner.py, whensignals.TestAbortAllis raised, theexceptblock only haspassand does not setok = False. This means if a test aborts before any failures, the suite exits with code 0 instead of 1.This is the same issue that was fixed in
test_runner.pyby PR #997 for issue #960, butrun_suite_class()insuite_runner.pywas missed.Fix
Change
passtook = Falsein theexcept signals.TestAbortAllblock so that aborting a test suite always results in a non-zero exit code.