Improve single element tensor handling - #3302
Merged
Merged
Conversation
asraa
approved these changes
Aug 5, 2026
| // once and splat it instead. | ||
| if (dataSemanticType && dataSemanticType.hasStaticShape() && | ||
| dataSemanticType.getNumElements() == 1 && | ||
| isDenseLayout(rel, targetType)) { |
Collaborator
There was a problem hiding this comment.
i think isDenseLayout takes some time and there's a small chance that it can both run up on line 374 and here - I think in the case that it's a splat tensor of some Value (not constant) with size one.
Collaborator
Author
There was a problem hiding this comment.
Good point. I folded this if into the preceding one, to avoid this
fold single element tensor in existing if
mdgrs
force-pushed
the
mdgrs/singleElementTensors
branch
from
August 5, 2026 14:50
b07076a to
7c361bc
Compare
j2kun
approved these changes
Aug 6, 2026
j2kun
added
the
pull_ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.