Define kernel dialect and kernel.eval_chebyshev op - #3282
Open
copybara-service[bot] wants to merge 1 commit into
Open
Define kernel dialect and kernel.eval_chebyshev op#3282copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_958763397
branch
4 times, most recently
from
August 5, 2026 03:05
acf1cc0 to
b8e5afb
Compare
This is change 1/8 demonstrating a high-level FHE kernel preservation for eval_chebyshev (and later, linear_transform). It defines the `kernel` dialect and `eval_chebyshev` op, along with a placeholder for the level consumption formula. PiperOrigin-RevId: 958763397
copybara-service
Bot
force-pushed
the
test_958763397
branch
from
August 5, 2026 04:36
b8e5afb to
6feb64a
Compare
AlexanderViand
left a comment
AlexanderViand
left a comment
Collaborator
There was a problem hiding this comment.
I like the kernel dialect name 👍
Comment on lines
+31
to
+32
| Builtin_FloatAttr:$domain_lower, | ||
| Builtin_FloatAttr:$domain_upper |
Collaborator
There was a problem hiding this comment.
I'm not sure we want to allow this on anything other than [-1,1] (i.e., drop the domain attr here and make it explicitly always [-1,1])?
Some backends (Cheddar, iirc) only support [-1,1] in their API, and for the others it's simply a convenience thing of not having to do the rescale/shift manually. For the compiler, it might be nicer to explicitly emit those ops so they can take part in CSE/etc?
Collaborator
however, it is not registered in heir-lsp :( |
Collaborator
I'll add that 🙃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define kernel dialect and kernel.eval_chebyshev op
This is change 1/8 demonstrating a high-level FHE kernel preservation for eval_chebyshev (and later, linear_transform). It defines the
kerneldialect andeval_chebyshevop, along with a placeholder for the level consumption formula.