Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
IlCommittatore
force-pushed
the
main
branch
6 times, most recently
from
f64791e to
6f3eb79
Compare
|
Thanks a lot for these changes! I am a bit concerned that tweaking lenient parsing like this could have undesired side-effects for other use cases. As mentioned in #2769 (comment), the proper solution might be if users explicitly added a separator between values when writing them to avoid ambiguities during parsing (see also #2783). However, I will leave this pull request open and let the direct project members decide since they might have a different opinion on this. |
| while (true) { | ||
| for (; pos + i < limit; i++) { | ||
| switch (buffer[pos + i]) { | ||
| case '"': |
There was a problem hiding this comment.
Maybe for consistency it would also be necessary to change JsonReader#skipUnquotedValue so that reading a value and skipping a value is consistent, and adding a test for this.
Not sure if JsonReader#isLiteral would have to be changed as well, maybe not.
2 participants
Purpose
Hello! I think this pull request could fix the issue with the id : #2769.
Closes #2769