Repository navigation
Escape control characters in natural UTF-8 JSON - #9451
Open
HocVoNgThai wants to merge 1 commit into
Open
HocVoNgThai wants to merge 1 commit into
HocVoNgThai wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When exporting JSON with
--natural-utf8,flatcwrites some control characters directly into string values instead of escaping them. The command succeeds, but the generated JSON is invalid and cannot be read by standard JSON parsers.For example, this valid input:
{"text": "café\u0000menu"}is exported with a raw NUL byte in place of
\u0000, causing JSON parsing to fail.This fix preserves
\u0000as an escape sequence while keepingcaféreadable, producing valid JSON without losing the original string content.The regression test covers all 32 control characters, checks that Unicode remains readable, and verifies that the generated JSON can be parsed again.