Repository navigation
reflection: bounds check field->id() in ForAllFields and FieldIdToIndex - #9445
Open
siddiqueirshad wants to merge 1 commit into
Open
siddiqueirshad wants to merge 1 commit into
siddiqueirshad wants to merge 1 commit into
Conversation
Check that field->id() is within vector bounds before indexing in ForAllFields and FieldIdToIndex to prevent heap out-of-bounds writes when processing schema buffers where field->id() exceeds the field count. Fixes google#9426 Signed-off-by: siddiqui irshad <mohdirshad1306@gmail.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bounds-check \ ield->id() < field_to_id_map.size()\ before writing into the field-id-to-index mapping in:
Fixes #9426.
Motivation
\ForAllFields()\ and \FieldIdToIndex()\ build a field-id-to-index table by writing \ ield_to_id_map[field->id()], where the vector is sized to \object->fields()->size(). If a schema buffer has a field whose \id()\ exceeds \ ields()->size(), direct array subscripting triggers an out-of-bounds heap write. Adding a bounds check ensures safe indexing without writing past the allocation.