fix(substrate): revert crashed actors instead of recreating them - #432
Merged
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Deleting and recreating a crashed actor discards its durable workspace and snapshot history. RevertActor returns it to SUSPENDED at its last snapshot; delete and recreate remains the fallback when the revert fails. Bumps agent-substrate/substrate to the commit that adds RevertActor.
AlexsJones
force-pushed
the
fix/revert-crashed-actor
branch
from
September 27, 2026 16:01
d29109c to
0a4d9a2
Compare
Member
|
We are going to revisit the entire task cycle once Agent Substrate lands the new actor lifecycle. I'm not sure if a a crashed actor should be automatically reverted to a previous state yet. It should be an explicit RPC call initiated by the client, the way Agent Substrate works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #431.
EnsureActornow callsRevertActoron a crashed actor, which returns it toSUSPENDEDat its last snapshot. If the revert fails, it falls back to the existing delete-and-recreate.RevertActorneeds a newer Substrate, so this bumpsagent-substrate/substrateto the commit that added it (agent-substrate/substrate#1675). That commit predates thereadyz→wakeupProbeandSnapshotsConfigrenames, so nothing else changes.Added a test that a crashed actor is reverted, not deleted. It fails without the fix;
go test -race ./...passes.