fs: default writeSecureFile to 0600 (owner-only)#155
Closed
1seal wants to merge 1 commit intogoogle-github-actions:mainfrom
Closed
fs: default writeSecureFile to 0600 (owner-only)#1551seal wants to merge 1 commit intogoogle-github-actions:mainfrom
1seal wants to merge 1 commit intogoogle-github-actions:mainfrom
Conversation
Author
|
closing as duplicate of #154 (same writeSecureFile 0600 change). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
writeSecureFilecurrently defaults to0o640, which makes created files group-readable. Since this helper is used to write credential material (directly or via downstream actions), this changes the default to0o600while keeping the ability for callers to overridemodeexplicitly.Changes:
writeSecureFiledefault mode to0o600modeCompatibility:
mode: 0o640explicitly.Testing:
npm testnpm run lint