Warn when sysid parameters have no modifier - #3509
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make a silent sysid configuration failure visible when a non-frozen
Parameterparticipates in the decision vector but hasmodifier=None.This is the failure mode behind #3286: a modifier factory can accidentally return
None, leaving the optimized value disconnected from theMjSpec. The optimizer then sees a zero gradient and can terminate immediately without explaining why.This change:
apply_param_modifiers_specis usedNoneParameterDict, avoiding log spam during repeated residual evaluationsapply_param_modifiers_specAddresses #3286.
Validation
The final branch is based directly on current
mainand contains one focused commit changing onlymodel_modifier.pyplus regression tests.The full sysid test environment was not executed locally here, so no local test pass is claimed.