Fix hidden skin array buffer - #3481
Merged
copybara-service[bot] merged 2 commits intoAug 25, 2026
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
sylvesterkaczmarek
marked this pull request as ready for review
August 15, 2026 20:12
SebasNorenaR
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3479.
mjr_renderuploads dynamic skin data to VBOs. When a skin is hidden, the resultingGL_ARRAY_BUFFERbinding can remain active.mjr_figureuses client-memory vertex arrays, so the stale VBO binding causes its pointers to be interpreted as buffer offsets and plotted lines can disappear.This change resets
GL_ARRAY_BUFFERbefore 2D rendering, ensuring client-array rendering starts from the expected OpenGL state.A regression test covers the hidden-skin →
mjr_figuresequence and verifies that the figure line is rendered.