satore: fix crash rendering a bare Var in literal->tptp-string - #740
Open
PratikDhanave wants to merge 1 commit into
Open
satore: fix crash rendering a bare Var in literal->tptp-string#740PratikDhanave wants to merge 1 commit into
PratikDhanave wants to merge 1 commit into
Conversation
The `Var?` branch of `literal->tptp-string` passed the whole `Var` struct to `Var-name->symbol`, but that function expects a Var *name* (a number, per its `exact-nonnegative-integer? -> symbol?` contract) and its `else` clause errors on anything else. So `(literal->tptp-string (Var 5))` raised "Var-name->symbol: Don't know what to do with #s(Var 5)" instead of returning "F". Extract the name first with `(Var-name lit)`, matching every other caller (`Vars->symbols`, the tests). The bug was latent because `clause->tptp-string` pre-converts Vars to symbols via `Vars->symbols`, so this branch is only reachable on a direct call.
|
Dooray! 메일 발송 실패 안내
메일 발송
실패 안내
***@***.***)
님께
보낸
메일이
전송되지
못하였습니다.
실패 사유를 확인해보세요.
* 받는 사람 :
***@***.***)
* 발송 시간 :
2026-07-25T15:10:56
* 메일 제목 :
[google-deepmind/deepmind-research] satore: fix crash rendering a bare Var in literal->tptp-string (PR #740)
* 실패 사유 :
받는 사람이 현재 메일 수신을 제한하고 있습니다.
이 설정은 개인 또는 조직의 메일 수신 정책에 의해 적용되었습니다.
이 메일은 발신전용으로 회신되지 않습니다.
더 궁금하신 사항은
***@***.***
으로 문의해 주시기 바랍니다.
© Dooray!.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Var?branch ofliteral->tptp-string(satore/tptp.rkt) crashes when handed a bare variable.[(Var? lit) (symbol->string (Var-name->symbol lit))] ; passes the whole structVar-name->symbol(unification.rkt) is documented asexact-nonnegative-integer? -> symbol?and itselseclause errors on anything that is not a number or symbol-variable. TheVar?guard has already establishedlitis aVarstruct, so its name must be extracted first.Concrete failure:
Fix — extract the name, matching every other caller (
Vars->symbols, the tests):The bug is latent in normal use because
clause->tptp-stringruns its input throughVars->symbolsfirst (which turns everyVarinto a symbol), so theVar?branch is only reached on a direct call.Testing
Verified by static tracing of
Var-name->symboland theVarstruct accessor. Reviewers can validate viaraco test satore/tests/.