Skip to content

_content/tour: handle PageUp/PageDown anywhere on a lesson page - #385

Open
thevilledev wants to merge 1 commit into
golang:masterfrom
thevilledev:fix/tour-page-keys
Open

thevilledev wants to merge 1 commit into
golang:masterfrom
thevilledev:fix/tour-page-keys

Conversation

@thevilledev

Copy link
Copy Markdown

The onpageup and onpagedown directives listened for keyup on
#editor-container only, so the keys stopped working as soon as the
focus moved outside of it. For example, to the theme toggle or the
"A Tour of Go" link in the top bar, or to the body after clicking on
empty space.

Listen on the document instead, as long as the editor view is
alive. Remove the handler when its scope is destroyed so that leaving
the lesson (e.g. for /tour/list) does not leave stale handlers behind.
Only handle the keys in the lesson, the top bar, or with nothing
focused, and keep ignoring them with Ctrl held or in editable fields
other than the code editor. Outside of the lesson, also leave them to
the browser when the page scrolls, as on narrow screens.

Fixes golang/go#81596

The onpageup and onpagedown directives listened for keyup on
#editor-container only, so the keys stopped working as soon as the
focus moved outside of it. For example, to the theme toggle or the
"A Tour of Go" link in the top bar, or to the body after clicking on
empty space.

Listen on the document instead, as long as the editor view is
alive. Remove the handler when its scope is destroyed so that leaving
the lesson (e.g. for /tour/list) does not leave stale handlers behind.
Only handle the keys in the lesson, the top bar, or with nothing
focused, and keep ignoring them with Ctrl held or in editable fields
other than the code editor. Outside of the lesson, also leave them to
the browser when the page scrolls, as on narrow screens.

Fixes golang/go#81596
@gopherbot

Copy link
Copy Markdown
Contributor

This PR (HEAD: 7762a52) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/website/+/844745.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

x/website/tour: PageUp and PageDown navigation stops working when focus is outside the tour editor

2 participants