Repository navigation
_content/tour: handle PageUp/PageDown anywhere on a lesson page - #385
Open
thevilledev wants to merge 1 commit into
Open
thevilledev wants to merge 1 commit into
thevilledev wants to merge 1 commit into
Conversation
The onpageup and onpagedown directives listened for keyup on #editor-container only, so the keys stopped working as soon as the focus moved outside of it. For example, to the theme toggle or the "A Tour of Go" link in the top bar, or to the body after clicking on empty space. Listen on the document instead, as long as the editor view is alive. Remove the handler when its scope is destroyed so that leaving the lesson (e.g. for /tour/list) does not leave stale handlers behind. Only handle the keys in the lesson, the top bar, or with nothing focused, and keep ignoring them with Ctrl held or in editable fields other than the code editor. Outside of the lesson, also leave them to the browser when the page scrolls, as on narrow screens. Fixes golang/go#81596
Contributor
|
This PR (HEAD: 7762a52) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/website/+/844745. Important tips:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The onpageup and onpagedown directives listened for keyup on
#editor-container only, so the keys stopped working as soon as the
focus moved outside of it. For example, to the theme toggle or the
"A Tour of Go" link in the top bar, or to the body after clicking on
empty space.
Listen on the document instead, as long as the editor view is
alive. Remove the handler when its scope is destroyed so that leaving
the lesson (e.g. for /tour/list) does not leave stale handlers behind.
Only handle the keys in the lesson, the top bar, or with nothing
focused, and keep ignoring them with Ctrl held or in editable fields
other than the code editor. Outside of the lesson, also leave them to
the browser when the page scrolls, as on narrow screens.
Fixes golang/go#81596