Open
Conversation
aymanbagabas
force-pushed
the
stash
branch
2 times, most recently
from
938e892 to
4e835a2
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #101 +/- ##
==========================================
+ Coverage 83.48% 83.61% +0.12%
==========================================
Files 29 30 +1
Lines 1841 1892 +51
==========================================
+ Hits 1537 1582 +45
- Misses 184 187 +3
- Partials 120 123 +3 |
- Add stash push - List - Show
unknwon
requested changes
Sep 30, 2024
Member
unknwon
left a comment
unknwon
left a comment
There was a problem hiding this comment.
Thanks for the PR! Left some comments.
Member
There was a problem hiding this comment.
Could you convert all if err != nil to require.NoError/require.Error/assert.Error accordingly?
Comment on lines
+56
to
+58
| if err != nil { | ||
| idx = -1 | ||
| } |
Member
There was a problem hiding this comment.
What does this mean to have Index == -1? Should we ignore the line instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
A clear and concise description of what the pull request is about, i.e. what problem should be fixed?
Link to the issue:
Checklist