Sync Ref to godotengine master.#1939
Merged
dsnopek merged 1 commit intogodotengine:masterfrom Mar 3, 2026
Merged
Conversation
Ivorforce
added
bug
Ivorforce
force-pushed
the
sync-ref
branch
2 times, most recently
from
8a733d8 to
391e7e5
Compare
dsnopek
approved these changes
Mar 3, 2026
Collaborator
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
Thanks!
I diff'd the version in godot-cpp against the one in Godot, and it looks good to me :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I deleted a few comments that aren't relelvant in godot-cpp, the rest is godotengine/master verbatim.
To make it work, I needed to flip the
Ref<->RefCounteddependency, such thatRefknowsRefCountedbut not vice versa. This matches the setup from upstream Godot.Should fix #1938