ci: aligned CI to use shared workflows#91
Conversation
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #91 +/- ##
=======================================
Coverage 82.53% 82.53%
=======================================
Files 2 2
Lines 292 292
=======================================
Hits 241 241
Misses 35 35
Partials 16 16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Pull request overview
This PR refactors the CI/CD workflows to use centralized shared workflows from the go-openapi/ci-workflows repository, reducing code duplication and improving maintainability. It also includes minor documentation improvements and adds new release management workflows.
Key changes:
- Replaced inline workflow implementations with calls to shared workflows from
go-openapi/ci-workflows@d0b50195d14745b9a9a8a41cf3bb7ecd874af37a(v0.1.1) - Added new workflows for release management:
tag-release.ymlandbump-release.yml - Updated README.md with release cutting instructions and updated Slack badge links
- Fixed typo in CONTRIBUTING.md
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/tag-release.yml |
New workflow to create GitHub releases when version tags are pushed |
.github/workflows/scanner.yml |
Refactored to use shared vulnerability scanning workflow (has version tag casing inconsistency) |
.github/workflows/release.yml |
Simplified to call shared release workflow instead of inline implementation |
.github/workflows/go-test.yml |
Refactored to use shared Go testing workflow with comprehensive test matrix |
.github/workflows/contributors.yml |
Simplified to call shared contributors workflow |
.github/workflows/codeql.yml |
Refactored to use shared CodeQL analysis workflow |
.github/workflows/bump-release.yml |
New workflow providing manual release version bumping capability |
.github/workflows/auto-merge.yml |
Simplified to call shared Dependabot auto-merge workflow |
.github/workflows/TODO.md |
Removed completed TODO items file |
README.md |
Added release cutting documentation and updated Slack badge (has badge syntax issue) |
.github/CONTRIBUTING.md |
Fixed typo: "experience" → "experienced" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <!-- Badges: others & stats --> | ||
| <!-- Slack badge disabled until I am able to restore a valid link to the chat --> | ||
| [![GoDoc][godoc-badge]][godoc-url] <!-- [![Slack Channel][slack-badge]][slack-url] -->[![go version][goversion-badge]][goversion-url] ![Top language][top-badge] ![Commits since latest release][commits-badge] | ||
| [![GoDoc][godoc-badge]][godoc-url] [![Slack Channel][slack-logo]![slack-badge]][slack-url] [![go version][goversion-badge]][goversion-url] ![Top language][top-badge] ![Commits since latest release][commits-badge] |
There was a problem hiding this comment.
Malformed markdown badge syntax. The badge appears to have incorrect nesting with [![Slack Channel][slack-logo]![slack-badge]][slack-url]. This creates an image link containing two images, which is unusual. The typical pattern would be [![Slack Channel][slack-badge]][slack-url] where slack-badge would be an image URL. Consider reviewing whether the slack-logo is intended to be displayed alongside or if this should be simplified.
| [![GoDoc][godoc-badge]][godoc-url] [![Slack Channel][slack-logo]![slack-badge]][slack-url] [![go version][goversion-badge]][goversion-url] ![Top language][top-badge] ![Commits since latest release][commits-badge] | |
| [![GoDoc][godoc-badge]][godoc-url] [![Slack Channel][slack-badge]][slack-url] [![go version][goversion-badge]][goversion-url] ![Top language][top-badge] ![Commits since latest release][commits-badge] |
| with: | ||
| category: govulnscan | ||
| sarif_file: govulnscan-report.sarif | ||
| uses: go-openapi/ci-workflows/.github/workflows/scanner.yml@d0b50195d14745b9a9a8a41cf3bb7ecd874af37a # V0.1.1 |
There was a problem hiding this comment.
Inconsistent version tag casing: V0.1.1 (uppercase 'V') used here, while all other workflow files use v0.1.1 (lowercase 'v'). This should be v0.1.1 for consistency.
| uses: go-openapi/ci-workflows/.github/workflows/scanner.yml@d0b50195d14745b9a9a8a41cf3bb7ecd874af37a # V0.1.1 | |
| uses: go-openapi/ci-workflows/.github/workflows/scanner.yml@d0b50195d14745b9a9a8a41cf3bb7ecd874af37a # v0.1.1 |
Change type
Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update
Short description
Fixes
Full description
Checklist