refactor: fix double error wrapping and harden code quality#19
Merged
Conversation
- Eliminate double error wrapping on readResponseBody call sites - Replace unsafe type assertion on SecureStore with local variable - Add constants for token store backend modes (auto, file, keyring) - Use specific error messages in exchangeDeviceCode and verifyToken - Remove obvious WHAT comments that duplicate code intent - Remove unnecessary generic type argument on NewSecureStore Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull request overview
Refactors the CLI’s OAuth/token-storage flow to improve error propagation, reduce panic risk, and remove stringly-typed configuration while keeping behavior consistent.
Changes:
- Eliminates double-wrapping of
readResponseBody()errors across multiple HTTP call sites. - Replaces
-token-storestring literals withtokenStoreModeAuto/File/Keyringconstants and removes an unsafe type assertion in the auto mode path. - Improves clarity of a few request failure error messages and removes redundant comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
readResponseBody()call sites that produced"failed to read response: failed to read response: <err>"tokenStore.(*credstore.SecureStore[...])with a local variable to prevent potential panicstokenStoreModeAuto/File/Keyringconstants to replace stringly-typed switch casesexchangeDeviceCodeandverifyTokenfor easier debugging// Create request with timeout,// Parse response) that duplicate code intentNewSecureStore(caught byinfertypeargslint)Test plan
make test— all tests passmake lint— zero issues🤖 Generated with Claude Code