feat: impl std::io::Write for SliceDeque<u8> - #84
Open
ErichDonGubler wants to merge 3 commits into
Open
ErichDonGubler wants to merge 3 commits into
ErichDonGubler wants to merge 3 commits into
Conversation
Author
|
Hmm, there are some failures in CI that are concerning to me as a user but I don't think have to do with this PR, since they also happen on
|
Author
|
@gnzlbg, ping! |
|
This would indeed be nice to have, (I need it too!) however, I think the owner of this repo is not active on github anymore... does anyone know any alternatives to this crate? |
|
@zyansheep Yes, this fork: https://github.com/LiquidityC/slice_ring_buffer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I haven't seen any discussion about this on this repo -- I've tried to do my homework, but I realize that this PR is out of the blue and hope that it's welcome. :) It should be a small commitment to review this, though, since the diff is small!
I've run into a case supporting some projects for
vivint-smarthomewhere havingstd::io::Writewould be particularly helpful for interoperation with compression crates likeflate2.This particular implementation comes straight from
std's implementation forVec<u8>. That means that the correctness of the implementation will just depend onSliceDeque::{extend_from_slice,reserve}having the same semantics as their counterparts inVec<u8>, which I believe is the case.