Skip to content

refactor(api): request and client types #2545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
setchy merged 8 commits into from
Jan 22, 2026
Merged

refactor(api): request and client types #2545

setchy merged 8 commits into from
Jan 22, 2026

Conversation

@setchy
Copy link
Member

@setchy setchy commented Jan 20, 2026 •
edited
Loading

Changes

  • Refactor api client and request functions
  • Remove AxiosPromise (old) and replace with Promise<AxiosResponse<T>>
  • Add types to REST function and response shape
  • Refactor client tests to verify client/request behavior, not raw axios call

To Do

  • Improve API response exception handling
  • Remove TODO

setchy added 4 commits January 20, 2026 07:23
@setchy
refactor(api): request function typing
811af9e 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
refactor(api): request function typing
24f2d24 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
refactor(api): request function typing
eb4d560 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
refactor(api): request function typing
9cc842d 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@github-actions github-actions bot added the refactor Refactoring of existing feature label Jan 20, 2026
@setchy setchy marked this pull request as draft January 20, 2026 20:01
This was linked to issues Jan 20, 2026
Improve API exception handling and logging #2544
Closed
used too much graphql api get rate limited #2537
Closed
@setchy setchy removed a link to an issue Jan 20, 2026
used too much graphql api get rate limited #2537
Closed
1 task
@setchy setchy mentioned this pull request Jan 20, 2026
Merged
setchy added 3 commits January 22, 2026 06:43
@setchy
Merge branch 'main' into refactor/api-request-shape-2
5431011 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
Merge branch 'main' into refactor/api-request-shape-2
a9bed25 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy
Merge branch 'main' into refactor/api-request-shape-2
0ba28fa 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy setchy marked this pull request as ready for review January 22, 2026 12:34
@setchy
Merge branch 'main' into refactor/api-request-shape-2
bcdcb60 
Signed-off-by: Adam Setch <adam.setch@outlook.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 22, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@setchy setchy merged commit 2565d21 into main Jan 22, 2026
13 of 14 checks passed
@setchy setchy deleted the refactor/api-request-shape-2 branch January 22, 2026 14:38
@github-actions github-actions bot added this to the Release 6.15.0 milestone Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@afonsojramos afonsojramos Awaiting requested review from afonsojramos afonsojramos is a code owner

@bmulholland bmulholland Awaiting requested review from bmulholland bmulholland is a code owner

Assignees

No one assigned

Labels

refactor Refactoring of existing feature

Milestone

Release 6.15.0

Development

Successfully merging this pull request may close these issues.

Improve API exception handling and logging

2 participants

@setchy