fix: add Python script routing to extension commands - #4734
AreebaxIrfan wants to merge 1 commit into
Conversation
|
Please make sure you also bump the catalog versions for each of these bundled extensions for this fix |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Git feature and auto-commit hooks omit required runtime arguments, and the rendering test does not exercise actual placeholder routing.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 2
Open (3)
What changed in this PR
Adds Python script metadata and routing tests for bundled extension commands.
Changes:
- Adds
sh,ps, andpyscript declarations to four commands. - Documents Python invocation paths.
- Adds routing and compatibility tests.
| File | Description |
|---|---|
extensions/git/commands/speckit.git.initialize.md |
Declares Python initialization script. |
extensions/git/commands/speckit.git.feature.md |
Declares and documents Python branch script. |
extensions/git/commands/speckit.git.commit.md |
Declares and documents Python auto-commit script. |
extensions/agent-context/commands/speckit.agent-context.update.md |
Declares Python context updater. |
tests/extensions/test_extension_command_py_scripts.py |
Tests extension script selection and paths. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| sh: scripts/bash/auto-commit.sh | ||
| ps: scripts/powershell/auto-commit.ps1 | ||
| py: scripts/python/auto_commit.py |
| sh: scripts/bash/create-new-feature-branch.sh --json | ||
| ps: scripts/powershell/create-new-feature-branch.ps1 -Json | ||
| py: scripts/python/create_new_feature_branch.py --json |
| # If the body contains {SCRIPT}, it must resolve to a Python invocation. | ||
| if "{SCRIPT}" in content: | ||
| assert "{SCRIPT}" not in result, f"{rel}: unresolved SCRIPT under py" | ||
| assert re.search( | ||
| rf"python3 \.specify/extensions/{re.escape(ext)}/scripts/python/\w+\.py", |
|
Could you describe a concrete failure this fixes for a project initialized with The frontmatter also enables hook dispatch. Drafted on behalf of @mnriem by GitHub Copilot (model: GPT-6 Sol, autonomous); comment fully AI-drafted. |


Description
Testing
uv run specify --helpuv sync && uv run pytestAI Disclosure
AI disclosure: N/A