Skip to content

Fix SC2129: group consecutive redirects in shell scripts #14594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 3 commits into from
Feb 9, 2026
Merged

Fix SC2129: group consecutive redirects in shell scripts #14594

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7a1938a
Initial plan
Copilot Feb 9, 2026
6263bde
Fix SC2129 shellcheck warnings by grouping consecutive redirects
Copilot Feb 9, 2026
75e1723
Add changeset [skip-ci]
github-actions[bot] Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/patch-group-github-output-redirects.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions actions/setup/js/mcp_server_core.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,9 +781,11 @@ echo "result=success" >> $GITHUB_OUTPUT
fs.writeFileSync(
handlerPath,
`#!/bin/bash
echo "first=value1" >> $GITHUB_OUTPUT
echo "second=value2" >> $GITHUB_OUTPUT
echo "third=value with spaces" >> $GITHUB_OUTPUT
{
echo "first=value1"
echo "second=value2"
echo "third=value with spaces"
} >> $GITHUB_OUTPUT
`,
{ mode: 0o755 }
);
Expand Down
8 changes: 5 additions & 3 deletions actions/setup/sh/start_mcp_gateway.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,9 @@ print_timing $SCRIPT_START_TIME "Overall gateway startup"
echo ""

# Output PID as GitHub Actions step output for use in cleanup
echo "gateway-pid=$GATEWAY_PID" >> $GITHUB_OUTPUT
# Output port and API key for use in stop script (per MCP Gateway Specification v1.1.0)
echo "gateway-port=${MCP_GATEWAY_PORT}" >> $GITHUB_OUTPUT
echo "gateway-api-key=${MCP_GATEWAY_API_KEY}" >> $GITHUB_OUTPUT
{
echo "gateway-pid=$GATEWAY_PID"
echo "gateway-port=${MCP_GATEWAY_PORT}"
echo "gateway-api-key=${MCP_GATEWAY_API_KEY}"
} >> $GITHUB_OUTPUT
Comment on lines +426 to +430
Copy link

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The redirect target is unquoted (} >> $GITHUB_OUTPUT). In this repo’s setup scripts we generally quote GitHub-provided file path vars (e.g. "$GITHUB_OUTPUT") to avoid SC2086-style word splitting/globbing and to keep output handling consistent with the other start_* scripts updated in this PR.

Copilot uses AI. Check for mistakes.
6 changes: 4 additions & 2 deletions actions/setup/sh/start_safe_inputs_server.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,5 +126,7 @@ for i in {1..10}; do
done

# Output the configuration for the MCP client
echo "port=$GH_AW_SAFE_INPUTS_PORT" >> "$GITHUB_OUTPUT"
echo "api_key=$GH_AW_SAFE_INPUTS_API_KEY" >> "$GITHUB_OUTPUT"
{
echo "port=$GH_AW_SAFE_INPUTS_PORT"
echo "api_key=$GH_AW_SAFE_INPUTS_API_KEY"
} >> "$GITHUB_OUTPUT"
6 changes: 4 additions & 2 deletions actions/setup/sh/start_safe_outputs_server.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,5 +126,7 @@ for i in {1..60}; do
done

# Output the configuration for the MCP client
echo "port=$GH_AW_SAFE_OUTPUTS_PORT" >> "$GITHUB_OUTPUT"
echo "api_key=$GH_AW_SAFE_OUTPUTS_API_KEY" >> "$GITHUB_OUTPUT"
{
echo "port=$GH_AW_SAFE_OUTPUTS_PORT"
echo "api_key=$GH_AW_SAFE_OUTPUTS_API_KEY"
} >> "$GITHUB_OUTPUT"
Loading