Rust: Fix context-based type inference explosion #21217
Draft
+152
−116
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following simple program would make our type inference implementation explode:
Firstly, because of a
getSuccessorvsgetAssocItembug,From::fromwould allow for any sub trait ofFrom, for example theInttrait, which meant thatxcould be inferred to have typebool. Secondly, since manyfromimplementations are polymorphic in their argument, we should really be checking that the return type matches the type of the calling context.This PR makes those two adjustments, and adds the regression test.