Actions: tolerate long ${{ ... }} expressions
#21211
Merged
+1,014
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These broke above about 300 characters because the regex in
getADelimitedExpressioncontained an alternation inside a quantifier that the Java regex engine couldn't work out could never backtrack in practice, due to the mutual exclusivity of the alternatives with both one another and the suffix. Combined with its usage of the call stack for backtracking, at four frames per character that meant an overflow occurred quite quickly.Fixed by making the quantifier possessive (
*+), so it never backtracks once an iteration is satisfied.I move the existing library tests into a subdirectory to avoid a new library test changing a wide variety of results, particularly ones that expose a ~100kb test string.