Disable reopen wontfix#234
Open
kzhou314 wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the “file” GitHub Action so that previously-closed scanner-filed issues are not reopened on subsequent runs when the issue is labeled wontfix, and documents the behavior for users.
Changes:
- Add
isWontfixIssue()helper and integrate it into the repeated-filing (reopen) path sowontfixissues stay closed. - Add Vitest coverage for the new label-check behavior, plus regression adjustments to existing tests.
- Document how to keep an issue closed using the
wontfixlabel.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents the wontfix label behavior for preventing reopen. |
| .github/actions/file/src/index.ts | Skips reopening repeated filings when the issue is labeled wontfix. |
| .github/actions/file/src/isWontfixIssue.ts | New helper to fetch issue labels and detect wontfix. |
| .github/actions/file/tests/wontfixReopen.test.ts | New end-to-end-ish test ensuring wontfix issues are not reopened. |
| .github/actions/file/tests/isWontfixIssue.test.ts | Unit tests for label detection and request routing. |
| .github/actions/file/tests/dryRun.test.ts | Updates regression guard to account for the new label-check GET request when not in dry-run. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 6/6 changed files
- Comments generated: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/accessibility/issues/10756.
Closing a scanner-filed issue without merging a fix used to cause it to reopen on the next run. Adding the
wontfixlabel now keeps it closed