Repository navigation
Fix identifiers associated with plain-text - #8307
Merged
Merged
Conversation
This was added in e252a56 as part of a mass-update to grammar submodules and their cached license files, a typical preparatory pre-release phase. It's unclear how this scope made it into `grammars.yml`, as the relevant grammar (atom-editorconfig) has only ever included the one grammar, with no references made to the `text.plain` scope.
Unlike other supported CodeMirror languages, plain-text defines no mode: https://github.com/codemirror/codemirror5/blob/9b4f060/mode/meta.js#L107
lildude
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that in e252a56 (as part of #4623), the
text.plainscope somehow slipped intogrammars.ymlunderneathvendor/grammars/atom-editorconfig, despite that submodule never once including a grammar with thetext.plainscope in its history (as it would have shadowed Atom's built-intext.plaingrammar, which it inherited from TextMate'sText.tmBundle).There's also no such grammar defined with that scope used anywhere in Linguist, for the simple reason that the trivial highlighting provided by TextMate's "Plain Text" syntax wouldn't show up on GitHub given the latter's restrictive scope-highlighting, and would probably distract readers if it did.
This pull-request removes the spurious inclusion, whilst also defining a CodeMirror MIME type for the Linguist's
Textlanguage (which CodeMirror curiously defines without an accompanying editor mode). I'm not sure how or if this is of benefit to folks running CodeMirror, but for the sake of completeness, I decided to add it toTextanyway while I was checking that itstm_scopefield didn't referencetext.plainanywhere.(Checklist omitted since it doesn't apply).