Skip to content

The most important PR - #15424

Merged
samhh merged 1 commit into
masterfrom
sah-branch-33
Aug 20, 2026
Merged

The most important PR#15424
samhh merged 1 commit into
masterfrom
sah-branch-33

Conversation

@samhh

@samhh samhh commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Now there's somewhere for all those Buzz dad jokes to live. (Feel free to revert if desired, just a bit of fun.)

Copilot AI lite review requested due to automatic review settings August 19, 2026 15:42
@github-actions github-actions Bot added screenshots Before/after UI screenshots are attached @gitbutler/lite labels Aug 19, 2026
@github-actions

Copy link
Copy Markdown

This pull request changes Lite's UI. Before/after screenshots make it
reviewable without checking the branch out.

To attach them, ask your agent for the lite-screenshots skill — it
captures both sides against seeded fixtures, publishes the surfaces that
changed, and posts them here.

Remove the screenshots label if this change is not visual.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a small “dad joke” footer to the Lite app’s workspace diff viewer, backed by a local JSON joke list, and updates TypeScript config to allow JSON imports.

Changes:

  • Enables resolveJsonModule in the Lite UI tsconfig so TypeScript can type-check JSON imports.
  • Introduces a getRandomDadJoke() helper and a bundled dad-jokes.json dataset.
  • Renders a random dad joke as a footer in the workspace CodeView UI and styles it via CSS modules.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
apps/lite/ui/tsconfig.json Enables JSON module resolution for typed JSON imports in the Lite UI project.
apps/lite/ui/src/routes/project/$id/workspace/Details.tsx Adds a DadJokeFooter component and wires it into CodeView via renderCodeViewFooter.
apps/lite/ui/src/routes/project/$id/workspace/Details.module.css Styles the new footer content (.dadJoke).
apps/lite/ui/src/dad-jokes.ts Adds a typed helper to pick a random joke from the bundled JSON list.
apps/lite/ui/src/dad-jokes.json Provides the dad joke dataset consumed by the UI.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@krlvi krlvi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Caleb-T-Owens

Copy link
Copy Markdown
Contributor

This is perfect

@samhh
samhh merged commit 5e4afb0 into master Aug 20, 2026
91 of 93 checks passed
@samhh
samhh deleted the sah-branch-33 branch August 20, 2026 08:35
@schacon

schacon commented Aug 20, 2026

Copy link
Copy Markdown
Member

I approve this message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@gitbutler/lite screenshots Before/after UI screenshots are attached

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants