Skip to content

Update Node version requirement to at least 24 - #15391

Closed
masecla22 wants to merge 2 commits into
gitbutlerapp:masterfrom
masecla22:patch-1
Closed

masecla22 wants to merge 2 commits into
gitbutlerapp:masterfrom
masecla22:patch-1

Conversation

@masecla22

Copy link
Copy Markdown

🧢 Changes

While setting up my development environment (for fixing a different issue), I noticed that Node 20 is in fact insufficient, even though the docs say that 20 should be enough. Changing to 22, since thats what the package.json says should be used.

Copilot AI lite review requested due to automatic review settings August 18, 2026 14:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates developer documentation to reflect a higher minimum Node.js version during local environment setup.

Changes:

  • Bumps the documented Node.js minimum version in the development setup guide from 20 to 22.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread DEVELOPMENT.md
@masecla22

Copy link
Copy Markdown
Author

The problem indeed goes deeper than just the docs say. I will update the PR to also change the engine in other places.

Copilot AI review requested due to automatic review settings August 18, 2026 16:04
@masecla22

Copy link
Copy Markdown
Author

I fixed it up everywhere, it should be good to go.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

Suppressed comments (2)

DEVELOPMENT.md:142

  • This line says “at least Node 22”, but the repo now enforces engines.node >=22.12.0 (and electron@43.3.0 requires that exact minimum). As written, someone installing 22.0–22.11 would still fail pnpm install. Please specify the same minimum patch version here to match the enforced requirement.
Next, ensure you've got at least Node 22 installed. If you're on Mac OS or Linux and you're missing `node`, you can use your favorite package manager like `brew` or `apt`.

e2e/README.md:22

  • For consistency with the enforced engines.node >=22.12.0, consider making this requirement explicit as v22.12.0+ (instead of v22.12+). That avoids ambiguity about whether 22.0.0 would work.
1. **Node.js** (v22.12+): See [DEVELOPMENT.md](../DEVELOPMENT.md) for installation

@masecla22

Copy link
Copy Markdown
Author

Heyyo @Byron anything else I need to do here?

@Byron

Byron commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Thanks, this looks good to me, despite the conflict.
I think @samhh should take this PR to completion as I could be missing a lot of details.

@Byron
Byron requested a review from samhh August 28, 2026 03:14
@samhh

samhh commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Hey @masecla22! I bumped us to the latest LTS this week (v24), but it looks like I missed some of the documentation you covered. Would you like to update it / is v24 working okay for you?

@Byron Byron added the feedback requested Feedback was requested to help resolve the issue label Aug 29, 2026
@masecla22 masecla22 changed the title Update Node version requirement to at least 22 Update Node version requirement to at least 24 Sep 2, 2026
Copilot AI review requested due to automatic review settings September 2, 2026 13:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The Node/pnpm version requirements are inconsistent across package.json, DEVELOPMENT.md, and e2e/README.md (and the PR title), which will confuse setup and enforcement.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (1)

DEVELOPMENT.md:142

  • This doc says “at least Node 22”, but the repo’s enforced minimum is >=22.12.0 via package.json engines (and Electron’s engines constraint). Consider documenting the patch-level minimum to reduce setup churn.
Next, ensure you've got at least Node 22 installed. If you're on Mac OS or Linux and you're missing `node`, you can use your favorite package manager like `brew` or `apt`.
  • Files reviewed: 3/3 changed files
  • Comments generated: 2
  • Review effort level: Lite

Comment thread e2e/README.md
Comment on lines +22 to 23
1. **Node.js** (v24+): See [DEVELOPMENT.md](../DEVELOPMENT.md) for installation
2. **pnpm** (v10.17.0): Enabled via `corepack enable` in the project root
Comment thread package.json
Comment on lines 5 to 7
"engines": {
"node": ">=20.11"
"node": ">=22.12.0"
},
@samhh

samhh commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Think this is all folded into 0b65136 now. Thanks for raising!

@samhh samhh closed this Sep 7, 2026
cbjeukendrup pushed a commit to cbjeukendrup/gitbutler that referenced this pull request Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feedback requested Feedback was requested to help resolve the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants