Make WriteOnly use only volatile writes.#9809
Draft
kpreid wants to merge 1 commit into
Draft
Conversation
We believe that this is necessary for `WriteOnly` to be sound, because a non-volatile write is technically permitted to be accompanied by extra reads or writes. There are no `const` volatile write operations, so we have to remove `const fn`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Part of #8897
Description
WriteOnlywithwrite_volatile().WriteOnlymust do the same.Per discussion in #8897, this is technically necessary for
WriteOnlyto be sound when used with write-combining memory, because a non-volatile write is permitted to be accompanied by extra reads or writes which might not behave, on write-combining memory, as expected by the optimizer.There are no
constvolatile write operations, so we have to removeconst fn.Testing
Tests pass. Documentation reviewed. However, ideally, benchmarks or assembly inspection would assure us that this does not have a large performance regression.
Squash or Rebase?
Rebase
Checklist
wgpumay be affected behaviorally.CHANGELOG.mdentries for the user-facing effects of this change are present.