Skip to content

fix(issues): Keep searched release selected in resolve modal#117496

Merged
scttcper merged 1 commit into
masterfrom
scttcper/fix-resolve-release-picker
Jun 12, 2026
Merged

fix(issues): Keep searched release selected in resolve modal#117496
scttcper merged 1 commit into
masterfrom
scttcper/fix-resolve-release-picker

Conversation

@scttcper

Copy link
Copy Markdown
Member

Selecting a release that only shows up through exact search made the resolve modal flip back to Version: None, even though the selected value was still there.

Keep the selected release around after search clears so the picker can still render its label, and add a regression test for that path.

Fixes #117488

Older releases can be found by exact search, but clearing the search after selection dropped that option from the picker list. CompactSelect still had the value, but no label to render, so it showed None.

Keep the selected release available after search clears and add a regression test for the search-only release path.

Fixes #117488

Co-authored-by: GPT-5 Codex <noreply@openai.com>
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 12, 2026
@scttcper scttcper marked this pull request as ready for review June 12, 2026 14:12
@scttcper scttcper requested review from a team June 12, 2026 14:13

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0daee14. Configure here.

visibleReleases.find(item => item.version === selectedVersion) ?? null;

setVersion(selectedVersion);
setSelectedRelease(release);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

onChange drops selectedRelease lookup

Medium Severity

The options list keeps a search-only release via selectedRelease when the debounced search is empty, but onChange resolves the chosen release only from exactRelease and the current releases fetch. If the user interacts with that option again after another search (or cached exact lookup no longer matches), lookup fails and selectedRelease is cleared while version stays set, so the Version trigger can show None again.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 0daee14. Configure here.

@scttcper scttcper merged commit 95a64d0 into master Jun 12, 2026
72 checks passed
@scttcper scttcper deleted the scttcper/fix-resolve-release-picker branch June 12, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve → "Another existing release…": selected release reverts to "Version: None" for releases outside the 100 most recent

2 participants