chore(alerts): Dont use legacy alerts endpoint in metric issue details#117482
Open
ceorourke wants to merge 1 commit into
Open
chore(alerts): Dont use legacy alerts endpoint in metric issue details#117482ceorourke wants to merge 1 commit into
ceorourke wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff
🔍 1 new type safety issue introducedType assertions (
This is informational only and does not block the PR. |
ceorourke
commented
Jun 11, 2026
| expect(await screen.findByText('Correlated Transactions')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('renders nothing and never hits the legacy alert-rules endpoint without a metric detector', () => { |
Member
Author
There was a problem hiding this comment.
idk how necessary this test is 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we are going to increase the brownout on the legacy alerts endpoints Kyle found that we are still using this legacy rules endpoint on the metric issue details page. This PR attempts (by attempts I mean I clauded my way to this and don't often write front end code so forgive my sins) to remove the fallback and replace the usage with a detector endpoint.