ref(components): Remove GroupTombstone from shared component props#110949
Merged
ref(components): Remove GroupTombstone from shared component props#110949
Conversation
The EventOrGroupHeader, EventOrGroupTitle, and EventOrGroupExtraDetails components previously accepted Event | Group | GroupTombstoneHelper but now only accept Group | GroupTombstoneHelper. With Event removed from the interface, the EventOrGroup prefix is no longer accurate, so rename: - EventOrGroupHeader → GroupTitleRow - EventOrGroupTitle → GroupTitle - EventOrGroupExtraDetails → GroupMetaRow Update all call sites, migrate tests from EventFixture to GroupFixture, and add missing assertions to render-only tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
Move tombstone rendering into groupTombstones.tsx, the only consumer that passes tombstone data. This simplifies the shared components: - GroupHeaderRow: data narrows from Group | GroupTombstoneHelper to Group - GroupTitle: data narrows from BaseGroup | GroupTombstoneHelper to BaseGroup - EventMessage: remove unused data prop entirely - createIssueLink: remove GroupTombstoneHelper from union - IssueSummary: remove dead isTombstone check and TitleWithoutLink Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
scttcper
force-pushed
the
scttcper/remove-tombstone-from-group-components
branch
from
fd6b49c to
98104d4
Compare
cvxluo
approved these changes
Mar 18, 2026
Contributor
cvxluo
left a comment
cvxluo
left a comment
There was a problem hiding this comment.
i think this needs a rebase but lgtm
…bstone-from-group-components # Conflicts: # static/app/components/feedback/feedbackItem/crashReportSection.tsx # static/app/components/groupHeaderRow.spec.tsx # static/app/components/groupHeaderRow.tsx # static/app/components/groupMetaRow.spec.tsx # static/app/components/groupTitle.spec.tsx # static/app/components/groupTitle.tsx # static/app/views/settings/project/projectFilters/groupTombstones.tsx
Both are only used internally within events.tsx — no external imports.
malwilley
approved these changes
Mar 18, 2026
Member
malwilley
left a comment
malwilley
left a comment
There was a problem hiding this comment.
RIP Group | GroupTombstoneHelper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #110937.
The only place that renders tombstones is
groupTombstones.tsx, so move the tombstone title/message rendering there instead of routing it throughGroupHeaderRow. This removesGroupTombstoneHelperfrom the prop types ofGroupHeaderRow,GroupTitle,EventMessage, andcreateIssueLink. Also removes the unuseddataprop fromEventMessage.