fix(ios): Guard replay postInit behind runtime session replay check by antonis · Pull Request #5858 · getsentry/sentry-react-native

antonis · 2026-03-20T14:12:42Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

Added a runtime check on options.sessionReplay.sessionSampleRate and options.sessionReplay.onErrorSampleRate before calling [RNSentryReplay postInit] in RNSentryStart.startWithOptions:.

Previously, postInit was only gated by the compile-time #if SENTRY_TARGET_REPLAY_SUPPORTED macro. When iOS deployment target >= 16.0, this macro is true, so postInit ran unconditionally — even when session replay was not configured. The breadcrumb converter installed by postInit referenced a nil replay instance, causing an ObjC exception. In New Architecture (TurboModules), void methods have no @try/@catch, so the exception propagated to std::terminate → SIGABRT.

💡 Motivation and Context

Fixes #5679

Users with iOS deployment target >= 16.0, New Architecture enabled, and no replay configured experienced a crash on launch in release builds. The crash was invisible to Sentry itself (since Sentry was what was crashing).

This was previously hidden because:

Deployment targets < 16.0 compile out the entire code path (SENTRY_TARGET_REPLAY_SUPPORTED = false)
Dev builds are more tolerant of native exceptions
All CI sample apps use deployment target 15.1

💚 How did you test it?

yarn build compiles without errors
yarn test — all 187 JS tests pass

Built the RNSentryCocoaTester Xcode project with IPHONEOS_DEPLOYMENT_TARGET=16.0 override (which enables SENTRY_TARGET_REPLAY_SUPPORTED):

cd packages/core/RNSentryCocoaTester
pod install --repo-update
xcodebuild build-for-testing \
  -workspace RNSentryCocoaTester.xcworkspace \
  -scheme RNSentryCocoaTester \
  -destination 'platform=iOS Simulator,name=iPhone 16' \
  IPHONEOS_DEPLOYMENT_TARGET=16.0

Result: TEST BUILD SUCCEEDED — confirms the fix compiles correctly when SENTRY_TARGET_REPLAY_SUPPORTED is true

Ran all 141 native iOS tests at deployment target 16.0:

xcodebuild test-without-building \
  -workspace RNSentryCocoaTester.xcworkspace \
  -scheme RNSentryCocoaTester \
  -destination 'platform=iOS Simulator,name=iPhone 16' \
  IPHONEOS_DEPLOYMENT_TARGET=16.0

Result: Executed 141 tests, with 0 failures — TEST EXECUTE SUCCEEDED

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

🔮 Next steps

Consider bumping at least one CI test target to iOS 16.0+ so this code path is exercised in CI going forward

When iOS deployment target >= 16.0, SENTRY_TARGET_REPLAY_SUPPORTED is true at compile time, but postInit was called unconditionally even when session replay was not configured. This caused a SIGABRT crash on launch in release builds with New Architecture (TurboModules) because the breadcrumb converter installed by postInit referenced a nil replay instance. Fixes #5679 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-03-20T14:13:05Z

Semver Impact of This PR

⚪ None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).

fix(ios): Guard replay postInit behind runtime session replay check by antonis in #5858

Add better needs_web check to CI by alwx in #5863
chore(deps): bump fast-xml-parser to ^5.5.7 by antonis in #5854
CI: detect-changes workflow to only check the affected components on the CI side by alwx in #5843
chore(deps): bump getsentry/craft/.github/workflows/changelog-preview.yml from 2.24.1 to 2.25.0 by dependabot in #5861
chore(deps): bump getsentry/craft from 2.24.1 to 2.25.0 by dependabot in #5862
chore(deps): bump github/codeql-action from 4.32.6 to 4.34.1 by dependabot in #5860
chore(deps): update JavaScript SDK to v10.45.0 by github-actions in #5848
chore(deps): bump flatted from 3.4.1 to 3.4.2 by dependabot in #5853
chore(deps): update Cocoa SDK to v9.8.0 by github-actions in #5847
fix(tracing): Guard getNewScreenTimeToDisplay behind enableTimeToInitialDisplay by antonis in #5849
chore(deps): bump json from 2.16.0 to 2.17.1.2 in /performance-tests by dependabot in #5844
chore(docs): Add changelog entry for duplicated breadcrumbs fix by antonis in #5851
fix(tracing): Unsubscribe spanEnd listeners after they fire to prevent accumulation by antonis in #5840
fix(android): Properly remove duplicated breadcrumbs by vovkasm in #5841
fix(tracing): Skip native frames and stall tracking for unsampled spans by antonis in #5842

_{🤖 This preview updates automatically when you update the PR.}

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

github-actions · 2026-03-20T14:41:03Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1235.30 ms	1232.89 ms	-2.41 ms
Size	3.38 MiB	4.73 MiB	1.35 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`ea3e26e`+dirty	1229.13 ms	1228.46 ms	-0.67 ms
`80e4616`+dirty	1221.32 ms	1225.64 ms	4.32 ms
`818a608`+dirty	1205.76 ms	1208.00 ms	2.24 ms
`77061ed`+dirty	1233.16 ms	1234.88 ms	1.71 ms
`bef3709`+dirty	1222.07 ms	1220.24 ms	-1.83 ms
`a206511`+dirty	1185.00 ms	1186.35 ms	1.35 ms
`74979ac`+dirty	1210.49 ms	1213.31 ms	2.82 ms
`a2bb688`+dirty	1223.53 ms	1232.90 ms	9.37 ms
`8a868fe`+dirty	1221.50 ms	1230.78 ms	9.28 ms
`d590428`+dirty	1211.77 ms	1220.51 ms	8.75 ms

App size

Revision	Plain	With Sentry	Diff
`ea3e26e`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`80e4616`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`818a608`+dirty	2.63 MiB	3.91 MiB	1.28 MiB
`77061ed`+dirty	2.63 MiB	3.98 MiB	1.34 MiB
`bef3709`+dirty	3.38 MiB	4.78 MiB	1.40 MiB
`a206511`+dirty	3.41 MiB	4.67 MiB	1.25 MiB
`74979ac`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`a2bb688`+dirty	2.63 MiB	3.99 MiB	1.36 MiB
`8a868fe`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`d590428`+dirty	3.38 MiB	4.78 MiB	1.39 MiB

github-actions · 2026-03-20T14:43:53Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	441.62 ms	442.70 ms	1.08 ms
Size	43.75 MiB	48.08 MiB	4.32 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`4a17c8f`+dirty	406.62 ms	400.58 ms	-6.04 ms
`df1f7df`+dirty	442.64 ms	427.16 ms	-15.48 ms
`a483f9f`+dirty	396.82 ms	453.28 ms	56.46 ms
`60cd796`+dirty	445.84 ms	492.45 ms	46.61 ms
`5c16cdc`+dirty	423.48 ms	452.35 ms	28.88 ms
`80e4616`+dirty	411.58 ms	462.12 ms	50.54 ms
`55b77fc`+dirty	411.87 ms	417.16 ms	5.29 ms
`bca62c0`+dirty	414.36 ms	451.06 ms	36.70 ms
`0b64753`+dirty	448.67 ms	474.61 ms	25.94 ms
`4e6d7d7`+dirty	480.73 ms	515.73 ms	35.00 ms

App size

Revision	Plain	With Sentry	Diff
`4a17c8f`+dirty	43.75 MiB	47.99 MiB	4.24 MiB
`df1f7df`+dirty	43.75 MiB	48.08 MiB	4.33 MiB
`a483f9f`+dirty	43.75 MiB	48.41 MiB	4.66 MiB
`60cd796`+dirty	43.75 MiB	48.07 MiB	4.32 MiB
`5c16cdc`+dirty	17.75 MiB	19.68 MiB	1.94 MiB
`80e4616`+dirty	43.75 MiB	48.55 MiB	4.80 MiB
`55b77fc`+dirty	43.75 MiB	47.99 MiB	4.24 MiB
`bca62c0`+dirty	43.75 MiB	48.41 MiB	4.66 MiB
`0b64753`+dirty	17.75 MiB	19.70 MiB	1.95 MiB
`4e6d7d7`+dirty	43.75 MiB	48.40 MiB	4.64 MiB

github-actions · 2026-03-20T15:18:17Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1222.42 ms	1225.26 ms	2.84 ms
Size	3.38 MiB	4.73 MiB	1.35 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`ea3e26e`+dirty	1216.61 ms	1214.15 ms	-2.47 ms
`80e4616`+dirty	1206.90 ms	1205.94 ms	-0.96 ms
`818a608`+dirty	1218.84 ms	1223.18 ms	4.34 ms
`77061ed`+dirty	1210.77 ms	1218.45 ms	7.68 ms
`bef3709`+dirty	1217.79 ms	1225.33 ms	7.54 ms
`a206511`+dirty	1225.02 ms	1223.74 ms	-1.28 ms
`74979ac`+dirty	1212.33 ms	1212.54 ms	0.21 ms
`a2bb688`+dirty	1244.82 ms	1238.60 ms	-6.22 ms
`8a868fe`+dirty	1206.85 ms	1215.04 ms	8.19 ms
`d590428`+dirty	1221.23 ms	1225.27 ms	4.03 ms

App size

Revision	Plain	With Sentry	Diff
`ea3e26e`+dirty	3.41 MiB	4.58 MiB	1.17 MiB
`80e4616`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`818a608`+dirty	3.19 MiB	4.48 MiB	1.29 MiB
`77061ed`+dirty	3.19 MiB	4.54 MiB	1.36 MiB
`bef3709`+dirty	3.38 MiB	4.78 MiB	1.40 MiB
`a206511`+dirty	3.41 MiB	4.67 MiB	1.25 MiB
`74979ac`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`a2bb688`+dirty	3.19 MiB	4.56 MiB	1.37 MiB
`8a868fe`+dirty	3.38 MiB	4.60 MiB	1.22 MiB
`d590428`+dirty	3.38 MiB	4.78 MiB	1.39 MiB

github-actions · 2026-03-20T15:19:42Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	372.78 ms	435.80 ms	63.02 ms
Size	43.94 MiB	48.93 MiB	5.00 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`70250df`+dirty	418.08 ms	480.84 ms	62.76 ms
`8d89cc9`+dirty	357.69 ms	415.79 ms	58.10 ms
`1853710`+dirty	360.67 ms	396.28 ms	35.61 ms
`55b77fc`+dirty	410.46 ms	414.11 ms	3.65 ms
`69602ce`+dirty	375.37 ms	405.28 ms	29.91 ms
`c1573b3`+dirty	355.65 ms	448.82 ms	93.17 ms
`90afdd3`+dirty	367.79 ms	404.84 ms	37.05 ms
`955f2eb`+dirty	388.13 ms	433.56 ms	45.44 ms
`80e4616`+dirty	427.31 ms	461.15 ms	33.84 ms
`276d348`+dirty	356.30 ms	405.27 ms	48.97 ms

App size

Revision	Plain	With Sentry	Diff
`70250df`+dirty	43.94 MiB	48.91 MiB	4.97 MiB
`8d89cc9`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`1853710`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`55b77fc`+dirty	43.94 MiB	48.82 MiB	4.88 MiB
`69602ce`+dirty	7.15 MiB	8.41 MiB	1.26 MiB
`c1573b3`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`90afdd3`+dirty	7.15 MiB	8.43 MiB	1.28 MiB
`955f2eb`+dirty	7.15 MiB	8.42 MiB	1.27 MiB
`80e4616`+dirty	43.94 MiB	49.38 MiB	5.44 MiB
`276d348`+dirty	7.15 MiB	8.42 MiB	1.26 MiB

alwx

Looks good, thanks!

lucas-zimerman

Nice fast fix!

antonis added the ready-to-merge Triggers the full CI test suite label Mar 20, 2026

fix(ios): Add changelog entry for replay postInit guard

74066ce

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

antonis marked this pull request as ready for review March 20, 2026 14:25

antonis requested review from alwx and lucas-zimerman as code owners March 20, 2026 14:25

Fixes lint issue

ce279a2

alwx approved these changes Mar 23, 2026

View reviewed changes

lucas-zimerman approved these changes Mar 23, 2026

View reviewed changes

antonis enabled auto-merge (squash) March 23, 2026 12:32

Merge branch 'main' into fix/guard-replay-postinit-5679

e301c50

antonis merged commit 2566c11 into main Mar 23, 2026
43 of 77 checks passed

antonis deleted the fix/guard-replay-postinit-5679 branch March 23, 2026 12:39

Uh oh!

Conversation

antonis commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Semver Impact of This PR

Uh oh!

github-actions bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Mar 20, 2026

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Mar 20, 2026

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

alwx left a comment

Choose a reason for hiding this comment

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

antonis commented Mar 20, 2026 •

edited

Loading

github-actions bot commented Mar 20, 2026 •

edited

Loading

github-actions bot commented Mar 20, 2026 •

edited

Loading

github-actions bot commented Mar 20, 2026 •

edited

Loading