Skip to content

feat(platform-redirect): alert for unavailable platforms for automated instrumentation#16833

Merged
aldy505 merged 4 commits intomasterfrom
aldy505/feat/automated-tracing-technical-limitation
Mar 12, 2026
Merged

feat(platform-redirect): alert for unavailable platforms for automated instrumentation#16833
aldy505 merged 4 commits intomasterfrom
aldy505/feat/automated-tracing-technical-limitation

Conversation

@aldy505
Copy link
Collaborator

@aldy505 aldy505 commented Mar 8, 2026

DESCRIBE YOUR PR

Closes DOCS-AAM

Actual link: https://docs.sentry.io/platform-redirect/?next=%2Ftracing%2Finstrumentation%2Fautomatic-instrumentation

My change:

image

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@vercel
Copy link

vercel bot commented Mar 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
develop-docs Ready Ready Preview, Comment Mar 11, 2026 3:57pm
sentry-docs Ready Ready Preview, Comment Mar 11, 2026 3:57pm

Request Review

Comment on lines 153 to +159
<Alert>{platformInfo}</Alert>
{isTracingAutomatedInstrumentation && (
<Alert>
This page lists only platforms with automated tracing instrumentation. Some
platforms may be omitted due to technical limitations.
</Alert>
)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Alert>{platformInfo}</Alert>
{isTracingAutomatedInstrumentation && (
<Alert>
This page lists only platforms with automated tracing instrumentation. Some
platforms may be omitted due to technical limitations.
</Alert>
)}
<Alert>
{platformInfo}
{isTracingAutomatedInstrumentation && (
<>
<br />
<br />
This page lists only platforms with automated tracing instrumentation. Some
platforms may be omitted due to technical limitations.
</>
)}
</Alert>

Maybe make this one alert so there's not alert fatigue? Or, if you want to keep them separate, let's change the color of the second:

{isTracingAutomatedInstrumentation && (
  <Alert level="warning">
    This page lists only platforms with automated tracing instrumentation. Some
    platforms may be omitted due to technical limitations.
  </Alert>
)}```

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep let's change the color.

@aldy505 aldy505 requested a review from sfanahata March 11, 2026 11:15
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Trailing slash causes alert to not display
    • The alert condition now normalizes a single trailing slash from pathname before comparison so both canonical and slash-suffixed URLs display the warning.

Create PR

Or push these changes by commenting:

@cursor push f98671e7e4
Preview (f98671e7e4)
diff --git a/app/platform-redirect/page.tsx b/app/platform-redirect/page.tsx
--- a/app/platform-redirect/page.tsx
+++ b/app/platform-redirect/page.tsx
@@ -31,7 +31,7 @@
 
   const pathname = sanitizeNext(next);
   const isTracingAutomatedInstrumentation =
-    pathname === '/tracing/instrumentation/automatic-instrumentation';
+    pathname.replace(/\/$/, '') === '/tracing/instrumentation/automatic-instrumentation';
   const rootNode = await getDocsRootNode();
   const defaultTitle = 'Platform Specific Content';
   let description = '';

This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

@aldy505
Copy link
Collaborator Author

aldy505 commented Mar 11, 2026

@cursor push f98671e

Normalize one trailing slash before comparing the redirect path for the\nautomated instrumentation notice. This preserves current routing behavior\nwhile ensuring the warning alert appears for equivalent URLs that end\nwith a slash.

Co-Authored-By: Claude <noreply@anthropic.com>

Applied via @cursor push command
Copy link
Contributor

@sfanahata sfanahata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@aldy505 aldy505 merged commit 221c187 into master Mar 12, 2026
19 checks passed
@aldy505 aldy505 deleted the aldy505/feat/automated-tracing-technical-limitation branch March 12, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants