feat(descriptions): Add more fine grained function.gcp span description rules - #624
Merged
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Attributes
Descriptions
Names
Other
Bug Fixes 🐛
Internal Changes 🔧Deps
Other
🤖 This preview updates automatically when you update the PR. |
Lms24
changed the title
Lms24
changed the title
Lms24
marked this pull request as ready for review
September 4, 2026 12:06
Lms24
requested review from
a team,
cleptric,
mjq and
nsdeschenes
as code owners
September 4, 2026 12:06
Lms24
changed the title
function.gcp span description rules
Lms24
added a commit
to getsentry/sentry-javascript
that referenced
this pull request
Sep 8, 2026
…an names (#24060) Adjusts `function.gcp` spans: - when span streaming is enabled, span names will be the function name (which we can read from env vars) or a string fallback - when disabled, we keep the current names. To ensure seamless static->streaming migrations, getsentry/sentry-conventions#624 adds new needed description rules to conventions. - added new `gcp.function.context` attributes which were previously only set on the transaction event context - adjusted unit tests and added tests for streaming names. We currently have no integration tests for gcp so this will have to do. ref #23954
nsdeschenes
approved these changes
Sep 8, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#617 added general FAAS description rules. After a more thorough SDK audit, we need to add more templates to ensure GCP serverless faas span descriptions are still correctly inferred like transaction-based spans set the span descriptions today.
Concrete changes:
function.gcpspans which includes GCP events, cloud events and http-invoked functionsPR Checklist
yarn testand verified that the tests pass.yarn generateto generate and format code and docs.If an attribute was added:
nextjs.function_id, notfunction_id)apply_scrubbing(i.e.manualorauto. Useneveronly for values that should never be scrubbed such as IDs)